feat(annotations): Disable target pointer-events when explicit creation #1262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConradJChan
commented
Sep 22, 2020
src/lib/viewers/doc/_docBase.scss
Outdated
|
|
||
| .annotationLayer { | ||
| .annotationLayer, | ||
| .ba-HighlightList .ba-HighlightSvg.is-listening .ba-HighlightTarget-rect, |
There was a problem hiding this comment.
I don't love how specific this rule has to be to override the existing styles, but this can be updated if we can make the underlying style less specific
2 tasks
ConradJChan
changed the title
mxiao6
reviewed
Sep 22, 2020
ConradJChan
force-pushed
the
create-region-pointer-events
branch
from
ab9aa32 to
d912111
Compare
ConradJChan
force-pushed
the
create-region-pointer-events
branch
from
d912111 to
6a62874
Compare
ConradJChan
commented
Sep 22, 2020
| default: | ||
| this.containerEl.classList.remove(CLASS_ANNOTATIONS_CREATE_REGION); | ||
| break; | ||
| if (this.containerEl) { |
There was a problem hiding this comment.
I removed the enableAnnotationsDiscoveribility clause because these classes can be applied with or without that feature. This allows explicit creation modes to disable existing annotations interactivity irrespective of discoverability
mxiao6
reviewed
Sep 22, 2020
mxiao6
approved these changes
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When in explicit annotation creation mode (highlight or region), all existing annotation targets should not be interact-able.