fix(discoverability): set mode to REGION instead of NONE

[ChenCodes]

• update toggleAnnotationMode to be called with REGION instead of NONE if FF is on
• update tests

Demo:

[ChenCodes]

Something that I noticed is that we have two toggleAnnotationMode method calls being made in the
handleFullscreenEnter -> disableAnnotationControls flow. My thinking is that either the first or second is redundant?

[mxiao6]

Good point. I think the first is redundant. @jstoffan can you confirm?

[jstoffan]

I'm not sure. It seems like these changes somewhat defeat the purpose of the original code, which was to forcibly disallow annotation creation. What effect does this have on creating annotations on rotated images, for example?

[ChenCodes]

My change was not in the right location, so I have moved it over to handleFullScreenExit instead.

[mxiao6]

I notice there is another this.annotator.toggleAnnotationMode call in handleAnnotationControlsEscape() and I believe it is also causing bug. Basically, I think we should wrap this.annotator.toggleAnnotationMode into another function with discovery FF logic and change all of the current this.annotator.toggleAnnotationMode calls to the new function. Does that sound reasonable?

[ChenCodes]

I notice there is another this.annotator.toggleAnnotationMode call in handleAnnotationControlsEscape() and I believe it is also causing bug. Basically, I think we should wrap this.annotator.toggleAnnotationMode into another function with discovery FF logic and change all of the current this.annotator.toggleAnnotationMode calls to the new function. Does that sound reasonable?

I'm not sure if we want to move all of the this.annotator.toggleAnnotation to the new function. The reason is that in some locations, we always want this.annotation.toggleAnnotationMode to be called with NONE because we are explicitly defining that the user should not be able to create regions. In other locations, we do want to set the default to be REGION (for example, in handleFullScreenExit, we do want to call it this.annotation.toggleAnnotationMode with REGION here if FF is on because we want the default mode to be REGION.