Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(annotations): Set region as default mode if discover FF is on #1255

Merged
merged 2 commits into from
Sep 15, 2020
Merged

feat(annotations): Set region as default mode if discover FF is on #1255

merged 2 commits into from
Sep 15, 2020

Conversation

mxiao6
Copy link
Contributor

@mxiao6 mxiao6 commented Sep 14, 2020 •
edited
Loading

@mxiao6 mxiao6 requested a review from a team as a code owner September 14, 2020 22:56
ConradJChan
ConradJChan reviewed Sep 14, 2020
View reviewed changes
src/lib/viewers/BaseViewer.js Outdated Show resolved Hide resolved
src/lib/viewers/BaseViewer.js Show resolved Hide resolved
@mxiao6 mxiao6 force-pushed the default-region branch 2 times, most recently from 49433fc to 14dc275 Compare September 15, 2020 20:57
ConradJChan
ConradJChan previously approved these changes Sep 15, 2020
View reviewed changes
src/lib/viewers/__tests__/BaseViewer-test.js Outdated Show resolved Hide resolved
@mergify mergify bot merged commit 9311be8 into box:master Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChenCodes ChenCodes ChenCodes left review comments

@jstoffan jstoffan jstoffan left review comments

@ConradJChan ConradJChan ConradJChan approved these changes

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mxiao6 @jstoffan @ChenCodes @ConradJChan