Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pdf): Upgrade pdf.js to v2.6.347 and closure compiler to v20200719 #1252

Merged
merged 1 commit into from
Oct 2, 2020
Merged

feat(pdf): Upgrade pdf.js to v2.6.347 and closure compiler to v20200719 #1252

merged 1 commit into from
Oct 2, 2020

Conversation

jstoffan
Copy link
Collaborator

@jstoffan jstoffan commented Sep 9, 2020 •
edited
Loading

Todo

  • Additional document testing
  • Cross-browser testing

@jstoffan jstoffan force-pushed the upgrade-pdfjs-26347 branch from 73e9ac8 to 81ebf32 Compare September 9, 2020 23:56
ConradJChan
ConradJChan reviewed Sep 10, 2020
View reviewed changes
build/karma.conf.js Outdated Show resolved Hide resolved
src/lib/viewers/doc/DocBaseViewer.js Outdated Show resolved Hide resolved
@jstoffan jstoffan marked this pull request as ready for review September 10, 2020 17:49
@jstoffan jstoffan requested a review from a team as a code owner September 10, 2020 17:49
ConradJChan
ConradJChan previously approved these changes Sep 10, 2020
View reviewed changes
ConradJChan
ConradJChan previously approved these changes Sep 10, 2020
View reviewed changes
@jstoffan jstoffan merged commit 296f23b into box:master Oct 2, 2020
@jstoffan jstoffan deleted the upgrade-pdfjs-26347 branch October 2, 2020 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ConradJChan ConradJChan ConradJChan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jstoffan @ConradJChan