feat(office): Add viewer option for max file size #1235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConradJChan
reviewed
Jul 14, 2020
|
Should probably change the title to indicate that viewer option for max size is being added, no need to mention appconf |
mxiao6
changed the title
ConradJChan
previously approved these changes
Jul 14, 2020
| // If the user does not have permission to download the file, the file is larger than 5MB, or isDisabledDueToSharedLink is true, | ||
| // then disable the Office viewer | ||
| const maxFileSize = getProp(viewerOptions, 'Office.maxFileSize', FIVE_MB); | ||
| // If the user does not have permission to download the file, the file is larger than Appconf file size or 5MB, |
There was a problem hiding this comment.
Appconf -- also maybe update to reflect the max file size rather than 5MB
ConradJChan
approved these changes
Jul 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.