Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(image): Disallow creation of annotations on rotated images #1232

Merged
merged 2 commits into from
Jul 1, 2020

Conversation

jstoffan
Copy link
Collaborator

@jstoffan jstoffan commented Jul 1, 2020

No description provided.

@@ -128,6 +128,13 @@ class ImageViewer extends ImageBaseViewer {
this.imageEl.style.transform = `rotate(${this.currentRotationAngle}deg)`;
this.emit('rotate');

// Disallow creating annotations on rotated images
if (this.currentRotationAngle === 0) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL: -0 === 0 is true

@mergify mergify bot merged commit 2e99220 into box:master Jul 1, 2020
@jstoffan jstoffan deleted the fix-annotations-image-rotated branch July 1, 2020 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants