fix(annotations): Fix region toggle button does not exit region mode #1228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstoffan
reviewed
Jun 22, 2020
ConradJChan
previously approved these changes
Jun 22, 2020
src/lib/viewers/BaseViewer.js
Outdated
| @@ -1055,10 +1055,13 @@ class BaseViewer extends EventEmitter { | |||
| * Handler for annotation toolbar region comment button click event. | |||
| * | |||
| * @private | |||
| * @param {boolean} activeControl - avtive control mode in AnnotationControls | |||
There was a problem hiding this comment.
acvtive -> active.
I believe we typically represent destructured arguments as:
@param {boolean} options.activeControl - ...
There was a problem hiding this comment.
Thank you for your feedback, I'll pay attention to those in my future PRs. I just removed this line in my latest commit.
jstoffan
reviewed
Jun 22, 2020
jstoffan
approved these changes
Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.