Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(annotations): Press Esc to exit annotations mode #1226

Merged
merged 3 commits into from
Jun 18, 2020
Merged

feat(annotations): Press Esc to exit annotations mode #1226

merged 3 commits into from
Jun 18, 2020

Conversation

mxiao6
Copy link
Contributor

@mxiao6 mxiao6 commented Jun 16, 2020 •
edited
Loading

  • Tests

jstoffan
jstoffan reviewed Jun 16, 2020
View reviewed changes
src/lib/AnnotationControls.ts Outdated Show resolved Hide resolved
src/lib/viewers/BaseViewer.js Outdated Show resolved Hide resolved
src/lib/viewers/BaseViewer.js Outdated Show resolved Hide resolved
src/lib/viewers/doc/DocBaseViewer.js Outdated Show resolved Hide resolved
jstoffan
jstoffan reviewed Jun 16, 2020
View reviewed changes
src/lib/viewers/BaseViewer.js Outdated Show resolved Hide resolved
src/lib/AnnotationControls.ts Outdated Show resolved Hide resolved
src/lib/AnnotationControls.ts Outdated Show resolved Hide resolved
src/lib/AnnotationControls.ts Outdated Show resolved Hide resolved
src/lib/AnnotationControls.ts Outdated Show resolved Hide resolved
src/lib/AnnotationControls.ts Outdated Show resolved Hide resolved
@mxiao6 mxiao6 marked this pull request as ready for review June 17, 2020 18:03
@mxiao6 mxiao6 requested a review from a team as a code owner June 17, 2020 18:03
jstoffan
jstoffan reviewed Jun 17, 2020
View reviewed changes
src/lib/AnnotationControls.ts Outdated Show resolved Hide resolved
src/lib/AnnotationControls.ts Show resolved Hide resolved
@jstoffan
Copy link
Collaborator

jstoffan commented Jun 18, 2020 •
edited
Loading

Seems worthwhile to add lifecycle tests for multiple init/destroy calls. Can be done in a follow-up, though.

@mergify mergify bot merged commit 96786d5 into box:master Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstoffan jstoffan jstoffan approved these changes

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxiao6 @jstoffan