feat(annotations): scroll to annotation on load #1224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mickr
commented
Jun 11, 2020
mickr
commented
- Add handler that will look for a set annotations activeId in the file options and if present, scroll to annotation.
* Add handler that will look for a set annotations activeId in the file options and if present, scroll to annotation.
ConradJChan
reviewed
Jun 11, 2020
jstoffan
reviewed
Jun 11, 2020
* PR Feedback to listen for event from annotations.
ConradJChan
reviewed
Jun 12, 2020
jstoffan
reviewed
Jun 12, 2020
* PR Feedback
* Update test
ConradJChan
previously approved these changes
Jun 12, 2020
jstoffan
reviewed
Jun 15, 2020
| file: { id }, | ||
| } = this.options; | ||
|
|
||
| const activeAnnotationId = getProp(this.options, `fileOptions.${id}.annotations.activeId`, null); |
There was a problem hiding this comment.
Is the null value meaningful here or does undefined serve the same purpose?
* PR Feedback
jstoffan
approved these changes
Jun 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.