fix(annotations): handle scrollToAnnotation in Preview #1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mickr
commented
May 28, 2020
mickr
commented
- Add handler to handle the scrolltoannotation event.
- Add override to PresentationViewer to setPage since we only show 1 page at a time.
jstoffan
reviewed
May 28, 2020
mickr
commented
May 28, 2020
ConradJChan
reviewed
May 28, 2020
|
Sorry, some duplicate comments |
jstoffan
previously approved these changes
May 28, 2020
* Add handler to handle the scrolltoannotation event. * Add override to PresentationViewer to setPage since we only show 1 page at a time.
* Updated handleScroll to call the annotators scroll method if id provided or pass the payload (string) to the method.
mickr
force-pushed
the
handle-scroll-annotation-for-presentations
branch
from
682a10c to
c119a4b
Compare
jstoffan
reviewed
May 30, 2020
* Updated test
jstoffan
approved these changes
Jun 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.