Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controls): update region annotation icon #1212

Merged
merged 3 commits into from
May 26, 2020

Conversation

mickr
Copy link
Contributor

@mickr mickr commented May 18, 2020

Updating to the newest region annotation icon. I increased the size a little bit because the new icon looked a bit small on the toolbar.

@mickr mickr requested a review from a team as a code owner May 18, 2020 18:28
@jstoffan
Copy link
Collaborator

Do we have a separate change for normalizing the padding of the toggle button with the thumbnail sidebar toggle button?

Copy link
Collaborator

@jstoffan jstoffan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you post some screenshots?

src/lib/AnnotationControls.scss Show resolved Hide resolved
src/lib/AnnotationControls.scss Outdated Show resolved Hide resolved
@mickr
Copy link
Contributor Author

mickr commented May 19, 2020

Default State
Screen Shot 2020-05-18 at 4 58 42 PM

Active State
Screen Shot 2020-05-18 at 4 58 51 PM

Focused State
Screen Shot 2020-05-18 at 4 59 01 PM

@mickr mickr force-pushed the update-annotation-control-icon branch from eebe4cc to 7b77b0e Compare May 21, 2020 21:15
src/lib/AnnotationControls.scss Show resolved Hide resolved
src/lib/AnnotationControls.scss Show resolved Hide resolved
src/lib/AnnotationControls.ts Outdated Show resolved Hide resolved
@mickr mickr force-pushed the update-annotation-control-icon branch from a62bc30 to 5268394 Compare May 23, 2020 01:37
@mergify mergify bot merged commit 699e859 into box:master May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants