fix(controls): stop event propagation from controls #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mickr
commented
May 14, 2020
mickr
commented
- Stop event propagation from preview controls, this is interfering with annotations.
- Add new tests for Controls.js constructor
* Stop event propagation from preview controls, this is interfering with annotations. * Add new tests for Controls.js constructor
jstoffan
reviewed
May 14, 2020
jstoffan
reviewed
May 14, 2020
* Remove comment
jstoffan
reviewed
May 18, 2020
| @@ -44,10 +44,10 @@ class Controls { | |||
| this.controlsEl.addEventListener('mouseleave', this.mouseleaveHandler); | |||
| this.controlsEl.addEventListener('focusin', this.focusinHandler); | |||
| this.controlsEl.addEventListener('focusout', this.focusoutHandler); | |||
| this.controlsEl.addEventListener('click', this.clickHandler); | |||
There was a problem hiding this comment.
Should we move the associated removeEventListener call out of its conditional check as well?
There was a problem hiding this comment.
Also, this component is used in all of the viewers across Preview, so this is a wide-ranging change. Does it have any side effects? Have we tested all the various viewers?
* remove listener from has touch clause
jstoffan
approved these changes
May 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.