feat(annotations): add support for passed annotations options #1206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mickr
commented
May 8, 2020
mickr
commented
- Add support for annotation options
- Use messages and locale if preset in options and forward them to the annotator to populate messages and locale
* Add support for annotation options that will populate intl object that gets passed to annotator if present.
mickr
force-pushed
the
add-annotations-option-handling
branch
from
cf3649b to
9a1a226
Compare
jstoffan
reviewed
May 8, 2020
* Add option to pass locale * PR Feedback
ConradJChan
approved these changes
May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.