feat(annotations): Support multiple annotations at a time #1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstoffan
approved these changes
Apr 29, 2020
| @@ -1105,9 +1105,6 @@ class BaseViewer extends EventEmitter { | |||
| // Only on success do we exit create annotation mode. If error occurs, | |||
| // we remain in create mode | |||
| if (status === 'success') { | |||
| const activeMode = this.annotationControls.getActiveMode(); | |||
| this.annotator.toggleAnnotationMode(activeMode); | |||
| this.annotationControls.resetControls(); | |||
| this.annotator.emit('annotations_active_set', id); | |||
There was a problem hiding this comment.
Do we want to remove this, as well? @ConradJChan @mickr
There was a problem hiding this comment.
yeah I think there's a separate ticket, might as well remove this whole handler while we're at it
There was a problem hiding this comment.
@ConradJChan If we remove the emit this will affect the setActive state when an annotation is created so we will need to follow up on it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.