feat(annotations): Hide annotation controls when fullscreen is active #1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstoffan
reviewed
Mar 30, 2020
mxiao6
force-pushed
the
hide-annotation-controls
branch
from
27dc600 to
bdfd7c9
Compare
jstoffan
reviewed
Mar 31, 2020
jstoffan
reviewed
Mar 31, 2020
ConradJChan
reviewed
Mar 31, 2020
Comment on lines
+108
to
+114
| if (regionButtonElement) { | ||
| this.isRegionActive = !this.isRegionActive; | ||
| if (this.isRegionActive) { | ||
| regionButtonElement.classList.add(CLASS_BUTTON_ACTIVE); | ||
| } else { | ||
| regionButtonElement.classList.remove(CLASS_BUTTON_ACTIVE); | ||
| } |
There was a problem hiding this comment.
Once the toggleAnnotationMode api is setup with the corresponding event, we may want to consider refactoring this to respond to the event instead so we can remove the local state maintained by AnnotationControls
jstoffan
approved these changes
Mar 31, 2020
ConradJChan
approved these changes
Mar 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.