fix(log): Fix log not getting serialized properly #1180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConradJChan
reviewed
Mar 12, 2020
src/lib/Preview.js
Outdated
| viewer_status: this.viewer.getLoadStatus(), | ||
| }, | ||
| value: previewDuration, | ||
| viewer_status: this.viewer.getLoadStatus(), |
There was a problem hiding this comment.
I don't think this will work because that field doesn't map to a column in the metrics table. You'll need to emit a separate event entirely
But this is not user facing? |
|
imo, it changes the functionality so I would change it to fix. Also chore won't get included in a release by itself I think |
ConradJChan
previously approved these changes
Mar 12, 2020
jstoffan
previously approved these changes
Mar 12, 2020
mxiao6
changed the title
ConradJChan
approved these changes
Mar 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.