feat(annotations): Send react-intl strings to annotations #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mickr
commented
Feb 7, 2020
mickr
commented
- Requires version upgrade of box-annotations
- Send react-intl strings to annotations
- Add shim for Intl and Karma
- Add resolver for lang files for annotations
- Remove redundant tags from index.html in test directory
- Use passed in language from ENV when building for dev
* Requires version upgrade of box-annotations * Add shim for Intl and Karma * Add resolver for lang files for annotations * Remove redundant tags from index.html in test directory * Use passed in language from ENV when building for dev
|
Verified that @mickr has signed the CLA. Thanks for the pull request! |
jstoffan
reviewed
Feb 7, 2020
mxiao6
reviewed
Feb 7, 2020
jstoffan
previously approved these changes
Feb 8, 2020
src/lib/intl.js
Outdated
| @@ -0,0 +1,37 @@ | |||
| import { IntlProvider, addLocaleData } from 'react-intl'; | |||
| import intlLocaleData from 'react-intl-locale-data'; // eslint-disable-line | |||
There was a problem hiding this comment.
Just FYI, this doesn't exist in [email protected].
There was a problem hiding this comment.
Correct, I have created the stories to upgrade to [email protected] for Preview and Annotations.
src/lib/intl.js
Outdated
| */ | ||
| const createAnnotatorIntl = () => { | ||
| addLocaleData(intlLocaleData); | ||
| const locale = language && language.substr(0, language.indexOf('-')); |
There was a problem hiding this comment.
Is the first identity check needed? Can this be inlined with the provider options?
|
Tests? |
jstoffan
previously approved these changes
Feb 8, 2020
src/lib/i18n.js
Outdated
| locale: language.substr(0, language.indexOf('-')), | ||
| messages: annotationMessages, | ||
| }, | ||
| {}, |
There was a problem hiding this comment.
I don't think this second object is required.
* Send over messages from Preview
jstoffan
approved these changes
Feb 10, 2020
| * @private | ||
| * @return {Object} | ||
| */ | ||
| const createAnnotatorIntl = () => { |
| */ | ||
| const createAnnotatorIntl = () => { | ||
| return { | ||
| messages: annotationMessages, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.