fix(archive): Folders come before files when sorting #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mxiao6
commented
Feb 5, 2020
mxiao6
commented
|
Verified that @mxiao6 has signed the CLA. Thanks for the pull request! |
mickr
reviewed
Feb 5, 2020
jstoffan
reviewed
Feb 5, 2020
| } | ||
|
|
||
| // folders always come before files | ||
| sortedItems.sort((a, b) => { |
There was a problem hiding this comment.
It seems like we should be able to collapse all of this into a single .sort call, with sortDirection controlling the comparator logic. Can we also check to see how webapp does this sorting? I don't see an equivalent complex sort function there.
jstoffan
previously approved these changes
Feb 6, 2020
| @@ -180,17 +185,15 @@ class ArchiveExplorer extends React.Component { | |||
| } | |||
|
|
|||
| if (typeof aItem === 'number' && typeof bItem === 'number') { | |||
| return aItem - bItem; | |||
| return sortDirection === SortDirection.ASC ? aItem - bItem : bItem - aItem; | |||
There was a problem hiding this comment.
How about flipping them at assignment to avoid the repeated logic?
const aItem = sortDirection === SortDirection.ASC ? a : b;
const bItem = sortdirection === SortDirection.ASC ? b : a;
There was a problem hiding this comment.
How about flipping them at assignment to avoid the repeated logic?
const aItem = sortDirection === SortDirection.ASC ? a : b; const bItem = sortdirection === SortDirection.ASC ? b : a;
Cannot flip them before null check below, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.