Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(archive): Fix inconsistent search cancel button in Expiring Embed #1161

Merged
merged 2 commits into from
Jan 28, 2020

Conversation

mxiao6
Copy link
Contributor

@mxiao6 mxiao6 commented Jan 27, 2020

No description provided.

@mxiao6 mxiao6 requested a review from a team as a code owner January 27, 2020 22:08
@boxcla
Copy link

boxcla commented Jan 27, 2020

Verified that @mxiao6 has signed the CLA. Thanks for the pull request!

mickr
mickr previously approved these changes Jan 28, 2020
jstoffan
jstoffan previously approved these changes Jan 28, 2020
Copy link
Collaborator

@jstoffan jstoffan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the PR title and commit message be updated?

@mxiao6 mxiao6 changed the title fix(archive): Fix missing cancel button of search bar fix(archive): Fix inconsistent search cancel button in Expiring Embed Jan 28, 2020
@mxiao6 mxiao6 removed the request for review from jstoffan January 28, 2020 19:52
@ConradJChan
Copy link
Contributor

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Jan 28, 2020

Command refresh: success

@mergify mergify bot merged commit dc2102d into box:master Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants