test(archive): Add e2e test #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @mxiao6 has signed the CLA. Thanks for the pull request! |
jstoffan
reviewed
Jan 17, 2020
| cy.get('button').click(); | ||
| }); | ||
|
|
||
| cy.get('.bp-SearchBar input').type('level'); |
There was a problem hiding this comment.
We should be using data-testid for selectors rather than CSS classes.
jstoffan
previously approved these changes
Jan 17, 2020
jstoffan
approved these changes
Jan 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test is failing because conversion feature flip is not on for our e2e test account. The account is live, so we have to wait until the next week. The test works on my dev vm.