feat(perf): Add new events to report modern performance metrics #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @jstoffan has signed the CLA. Thanks for the pull request! |
jstoffan
force-pushed
the
perf-metrics
branch
2 times, most recently
from
f704338 to
7818f3f
Compare
mxiao6
reviewed
Jan 6, 2020
src/lib/Preview.js
Outdated
| @@ -560,13 +560,10 @@ class Preview extends EventEmitter { | |||
| }); | |||
| } | |||
|
|
|||
| const downloadAttemptEvent = { | |||
| this.emit(PREVIEW_METRIC, { | |||
There was a problem hiding this comment.
Should this to be emitLogEvent?
There was a problem hiding this comment.
Nice catch, thanks.
mxiao6
reviewed
Jan 6, 2020
jstoffan
force-pushed
the
perf-metrics
branch
2 times, most recently
from
4d8d949 to
979b746
Compare
mickr
previously approved these changes
Jan 8, 2020
mickr
approved these changes
Jan 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.