feat(archive): Add archive loader to prepare for conversion feature flip #1137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @mxiao6 has signed the CLA. Thanks for the pull request! |
jstoffan
reviewed
Dec 31, 2019
| @@ -93,8 +93,7 @@ export const STATUS_SUCCESS = 'success'; | |||
| export const STATUS_VIEWABLE = 'viewable'; | |||
|
|
|||
| // X-Rep-Hints for Representations API | |||
| export const X_REP_HINT_ARCHIVE = '[json]'; | |||
| export const X_REP_HINT_BASE = '[3d][pdf][text][mp3]'; | |||
| export const X_REP_HINT_BASE = '[3d][pdf][text][mp3][json]'; | |||
There was a problem hiding this comment.
This rep will now be hinted for every file. Did we check with the conversion team regarding the performance impact of this change?
There was a problem hiding this comment.
This rep will now be hinted for every file. Did we check with the conversion team regarding the performance impact of this change?
Yeah, they said it's ok.
jstoffan
approved these changes
Jan 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If conversion feature flip is not enabled for a user, the user will see the error message "We're sorry, your account is unable to preview this file type."