chore(types): Add support for typescript and add types to api module #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @jstoffan has signed the CLA. Thanks for the pull request! |
priyajeet
reviewed
Dec 21, 2019
jstoffan
force-pushed
the
typescript
branch
2 times, most recently
from
0b14bf6 to
969cfca
Compare
priyajeet
previously approved these changes
Dec 21, 2019
src/lib/viewers/text/BoxCSV.js
Outdated
| @@ -65,6 +65,10 @@ class BoxCSV { | |||
| }; | |||
| /* eslint-enable react/prop-types */ | |||
|
|
|||
| setRef = gridComponent => { | |||
There was a problem hiding this comment.
Guessing you didn't want to switch to React.createRef() to minimize further refactoring
priyajeet
reviewed
Dec 21, 2019
priyajeet
previously approved these changes
Dec 21, 2019
mickr
previously approved these changes
Dec 21, 2019
j3tan
approved these changes
Dec 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I converted the API module mostly as an example and to test the build/lint steps.