chore(build): Add dry run option #1116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @mickr has signed the CLA. Thanks for the pull request! |
jstoffan
previously approved these changes
Dec 13, 2019
| @@ -6,6 +6,19 @@ export NODE_PATH=$NODE_PATH:./node_modules | |||
| OLD_VERSION="XXX" | |||
| VERSION="XXX" | |||
|
|
|||
| dry_run=false | |||
There was a problem hiding this comment.
It looks like our current variables follow SNAKE_CAPS convention.
There was a problem hiding this comment.
Most of the variables do, our switches do not. Since this was a command line switch I made it look like the others
|
I think the scope should probably be |
mickr
force-pushed
the
optimize-build
branch
from
a6acdae to
b0dfafb
Compare
mickr
force-pushed
the
optimize-build
branch
from
b0dfafb to
bbfe0db
Compare
jstoffan
changed the title
jstoffan
approved these changes
Dec 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding dry_run option to release script for easier testing.