feat(icons): Update file icons to match latest design language #1109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @jstoffan has signed the CLA. Thanks for the pull request! |
jstoffan
commented
Nov 23, 2019
| @@ -78,7 +78,6 @@ const FILE_LOADING_ICONS = { | |||
| FILE_BOX_NOTE, | |||
| FILE_CODE, | |||
| FILE_DEFAULT, | |||
| FILE_DICOM, | |||
There was a problem hiding this comment.
We're missing a DICOM-specific icon in the new set, but .dcm files were already using the FILE_IMAGE icon. I'll update if I hear otherwise from design.
jstoffan
force-pushed
the
update-icons
branch
from
772b602 to
8e3fba1
Compare
jstoffan
force-pushed
the
update-icons
branch
from
8e3fba1 to
6cd0424
Compare
mickr
approved these changes
Nov 23, 2019
booc0mtaco
approved these changes
Nov 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should figure out a way to ingest the icons and their map from box-ui-elements, but given our time constraints, that can wait for another day.