feat(zoom controls): Restyle zoom controls #1092

ConradJChan · 2019-10-30T20:04:59Z

Updated the zoom controls across Documents, Images, and Plain Text viewers.

TODO:

Unit Tests

Document Viewer:

Plain Text Viewer:

Image Viewer:

MultiImage Viewer:

boxcla · 2019-10-30T20:05:02Z

Verified that @ConradJChan has signed the CLA. Thanks for the pull request!

src/lib/ZoomControls.js

src/lib/Controls.scss

src/lib/icons/zoom_in_16px.svg

src/lib/icons/zoom_out_16px.svg

src/lib/viewers/image/ImageBaseViewer.js

src/lib/ZoomControls.js

src/lib/Controls.js

src/lib/ZoomControls.js

src/lib/Controls.js

src/lib/icons/zoom_in.svg

src/lib/viewers/doc/DocBaseViewer.js

src/lib/viewers/image/MultiImageViewer.js

src/lib/viewers/text/TextBaseViewer.js

src/lib/viewers/text/__tests__/TextBaseViewer-test.js

jstoffan

Code changes look good. I think the spacing of each group of controls (page and zoom) looks a little awkward. The buttons seem too far away from the inner content and each group seems too far away from each other.

src/lib/viewers/image/MultiImageViewer.js

refactor(zoom controls): Restyle zoom controls

c887a21

ConradJChan requested a review from a team as a code owner October 30, 2019 20:04

mickr reviewed Oct 30, 2019

View reviewed changes

src/lib/ZoomControls.js Show resolved Hide resolved

Conrad Chan added 2 commits October 30, 2019 16:06

chore: addressing PR comments and fixing unit tests

9d78562

chore: adding tests for ZoomControls.js

78abfb7

sahiga reviewed Oct 31, 2019

View reviewed changes

src/lib/Controls.scss Show resolved Hide resolved

src/lib/icons/zoom_in_16px.svg Outdated Show resolved Hide resolved

src/lib/icons/zoom_out_16px.svg Outdated Show resolved Hide resolved

src/lib/viewers/image/ImageBaseViewer.js Show resolved Hide resolved

manishPh reviewed Oct 31, 2019

View reviewed changes

src/lib/ZoomControls.js Show resolved Hide resolved

src/lib/ZoomControls.js Show resolved Hide resolved

manishPh reviewed Oct 31, 2019

View reviewed changes

src/lib/Controls.js Show resolved Hide resolved

src/lib/ZoomControls.js Outdated Show resolved Hide resolved

chore: address PR comments

df80b02

jstoffan reviewed Oct 31, 2019

View reviewed changes

Conrad Chan added 2 commits October 31, 2019 16:10

chore: address PR comments

45cf182

chore: PR comments

8bec687

jstoffan previously approved these changes Oct 31, 2019

View reviewed changes

src/lib/viewers/image/MultiImageViewer.js Outdated Show resolved Hide resolved

chore: PR comments

b81f028

ConradJChan dismissed jstoffan’s stale review via b81f028 November 1, 2019 16:55

ConradJChan changed the title ~~refactor(zoom controls): Restyle zoom controls~~ feat(zoom controls): Restyle zoom controls Nov 4, 2019

mickr approved these changes Nov 4, 2019

View reviewed changes

ConradJChan added the ready-to-merge label Nov 5, 2019

Merge branch 'master' into zoom-restyle

026ef5b

mergify bot merged commit a9e66bf into box:master Nov 5, 2019

ConradJChan deleted the zoom-restyle branch November 5, 2019 23:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(zoom controls): Restyle zoom controls #1092

feat(zoom controls): Restyle zoom controls #1092

ConradJChan commented Oct 30, 2019 •

edited

Loading

boxcla commented Oct 30, 2019

jstoffan left a comment

feat(zoom controls): Restyle zoom controls #1092

feat(zoom controls): Restyle zoom controls #1092

Conversation

ConradJChan commented Oct 30, 2019 • edited Loading

boxcla commented Oct 30, 2019

jstoffan left a comment

Choose a reason for hiding this comment

ConradJChan commented Oct 30, 2019 •

edited

Loading