Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(examples): Provide example for startAt option #1080

Merged
merged 2 commits into from
Oct 2, 2019

Conversation

jstoffan
Copy link
Collaborator

Closes #1079.

@jstoffan jstoffan requested a review from a team as a code owner September 25, 2019 21:36
@boxcla
Copy link

boxcla commented Sep 25, 2019

Verified that @jstoffan has signed the CLA. Thanks for the pull request!

ConradJChan
ConradJChan previously approved these changes Sep 25, 2019
README.md Outdated

| Start At | Description |
| -------- | ------------------------------------------------------------- |
| unit | Supported values: "pages" for documents; "seconds" for videos |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe media instead of videos?

manishPh
manishPh previously approved these changes Sep 25, 2019
@jstoffan jstoffan dismissed stale reviews from manishPh and ConradJChan via 764b20f September 25, 2019 21:45
@mickr
Copy link
Contributor

mickr commented Oct 2, 2019

I kicked off the e2e tests again but they are still failing.

@mergify mergify bot merged commit 5011b81 into box:master Oct 2, 2019
@jstoffan jstoffan deleted the docs-start-at branch March 4, 2020 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parameter startAt does not work with PDF files
5 participants