Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(viewer): Re-enable support for range requests for most users #1072

Merged
merged 3 commits into from
Sep 16, 2019

Conversation

mxiao6
Copy link
Contributor

@mxiao6 mxiao6 commented Sep 16, 2019

No description provided.

@mxiao6 mxiao6 requested a review from jstoffan September 16, 2019 21:19
@mxiao6 mxiao6 requested a review from a team as a code owner September 16, 2019 21:19
@boxcla
Copy link

boxcla commented Sep 16, 2019

Verified that @mxiao6 has signed the CLA. Thanks for the pull request!

Copy link
Contributor

@ConradJChan ConradJChan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to see this reflected in the unit tests to make sure this is what we expect it to be

jstoffan
jstoffan previously approved these changes Sep 16, 2019
@mxiao6 mxiao6 changed the title fix(viewer): change back disableRange logic fix(viewer): Re-enable support for range requests for most users Sep 16, 2019
@mergify mergify bot merged commit 83424d0 into box:master Sep 16, 2019
@mxiao6 mxiao6 deleted the 6830-gzip branch December 11, 2019 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants