-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dashviewer): Video performance instrumentation #1071
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Verified that @ConradJChan has signed the CLA. Thanks for the pull request! |
mickr
reviewed
Sep 13, 2019
Seems like this is more than a chore to me |
ConradJChan
changed the title
chore(dashviewer): Video performance instrumentation
feat(dashviewer): Video performance instrumentation
Sep 13, 2019
jstoffan
reviewed
Sep 13, 2019
jstoffan
reviewed
Sep 17, 2019
jstoffan
reviewed
Sep 17, 2019
jstoffan
approved these changes
Sep 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces two new metric events:
media_metric_buffer_fill
which represents the initial buffering before playback can beginmedia_metric_end_playback
which contains metrics around total buffering time, lag/watch ratio, etc...media_metric_buffer_fill
will be emitted as soon as it is measured.media_metric_end_playback
will be emitted in 3 scenarios:ended
event is fired)As part of this PR, only the
DashViewer
will emit these metrics.TODO: