Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashviewer): Video performance instrumentation #1071

Merged
merged 15 commits into from
Sep 17, 2019

Conversation

ConradJChan
Copy link
Contributor

@ConradJChan ConradJChan commented Sep 13, 2019

Introduces two new metric events:

  • media_metric_buffer_fill which represents the initial buffering before playback can begin
  • media_metric_end_playback which contains metrics around total buffering time, lag/watch ratio, etc...

media_metric_buffer_fill will be emitted as soon as it is measured.

media_metric_end_playback will be emitted in 3 scenarios:

  1. when playback is finished (ended event is fired)
  2. when the viewer is destroyed (when preview is closed)
  3. when the page unloads

As part of this PR, only the DashViewer will emit these metrics.

TODO:

  • fix unit tests
  • add new unit tests

@ConradJChan ConradJChan requested a review from a team as a code owner September 13, 2019 17:50
@boxcla
Copy link

boxcla commented Sep 13, 2019

Verified that @ConradJChan has signed the CLA. Thanks for the pull request!

@mickr
Copy link
Contributor

mickr commented Sep 13, 2019

Seems like this is more than a chore to me

@ConradJChan ConradJChan changed the title chore(dashviewer): Video performance instrumentation feat(dashviewer): Video performance instrumentation Sep 13, 2019
src/lib/viewers/media/DashViewer.js Outdated Show resolved Hide resolved
src/lib/viewers/media/DashViewer.js Show resolved Hide resolved
src/lib/viewers/media/DashViewer.js Outdated Show resolved Hide resolved
src/lib/viewers/media/DashViewer.js Outdated Show resolved Hide resolved
src/lib/viewers/media/DashViewer.js Outdated Show resolved Hide resolved
src/lib/viewers/media/DashViewer.js Outdated Show resolved Hide resolved
src/lib/viewers/media/DashViewer.js Outdated Show resolved Hide resolved
src/lib/viewers/media/MediaBaseViewer.js Outdated Show resolved Hide resolved
src/lib/viewers/media/MediaBaseViewer.js Show resolved Hide resolved
src/lib/viewers/media/DashViewer.js Outdated Show resolved Hide resolved
src/lib/viewers/media/DashViewer.js Outdated Show resolved Hide resolved
src/lib/viewers/media/DashViewer.js Outdated Show resolved Hide resolved
src/lib/viewers/media/DashViewer.js Show resolved Hide resolved
src/lib/viewers/media/MediaBaseViewer.js Outdated Show resolved Hide resolved
src/lib/viewers/media/MediaBaseViewer.js Outdated Show resolved Hide resolved
src/lib/viewers/media/MediaBaseViewer.js Outdated Show resolved Hide resolved
src/lib/viewers/media/MediaBaseViewer.js Show resolved Hide resolved
src/lib/viewers/media/MediaBaseViewer.js Show resolved Hide resolved
src/lib/viewers/media/DashViewer.js Outdated Show resolved Hide resolved
src/lib/viewers/media/DashViewer.js Outdated Show resolved Hide resolved
src/lib/viewers/media/DashViewer.js Show resolved Hide resolved
src/lib/viewers/media/MediaBaseViewer.js Outdated Show resolved Hide resolved
@mergify mergify bot merged commit ed492c1 into box:master Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants