fix(preview): remove auto-preview experience #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @mxiao6 has signed the CLA. Thanks for the pull request! |
ConradJChan
reviewed
Sep 10, 2019
| @@ -44,7 +44,6 @@ class MediaBaseViewer extends BaseViewer { | |||
| this.toggleMute = this.toggleMute.bind(this); | |||
| this.handleRate = this.handleRate.bind(this); | |||
| this.handleAutoplay = this.handleAutoplay.bind(this); | |||
| this.mediaendHandler = this.mediaendHandler.bind(this); | |||
There was a problem hiding this comment.
I think leaving in this event is still fine, we just don't need to react to it internally in the preview sdk
mxiao6
force-pushed
the
6915-remove-auto-preview
branch
from
e445b8c to
184bade
Compare
mxiao6
force-pushed
the
6915-remove-auto-preview
branch
from
184bade to
b35b80d
Compare
jstoffan
reviewed
Sep 10, 2019
src/lib/Preview.js
Outdated
| @@ -1239,7 +1239,6 @@ class Preview extends EventEmitter { | |||
| this.ui.finishProgressBar(); | |||
| break; | |||
| case VIEWER_EVENT.mediaEndAutoplay: | |||
There was a problem hiding this comment.
This entire condition can be removed, as it's now a no-op.
There was a problem hiding this comment.
Actually, it looks like it's preventing the event from being forwarded by the default condition.
There was a problem hiding this comment.
Then the test for it should be removed entirely too, right?
There was a problem hiding this comment.
or change it to test the default condition
ConradJChan
approved these changes
Sep 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.