Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(viewer): Update volume icon after UI is loaded #1066

Merged
merged 3 commits into from
Sep 6, 2019

Conversation

mxiao6
Copy link
Contributor

@mxiao6 mxiao6 commented Sep 4, 2019

No description provided.

@mxiao6 mxiao6 requested a review from a team as a code owner September 4, 2019 20:29
@boxcla
Copy link

boxcla commented Sep 4, 2019

Verified that @mxiao6 has signed the CLA. Thanks for the pull request!

@jstoffan
Copy link
Collaborator

jstoffan commented Sep 4, 2019

Does this work for Dash videos? It looks like loadeddataHandler is overridden in DashViewer.

@mxiao6
Copy link
Contributor Author

mxiao6 commented Sep 4, 2019

Does this work for Dash videos? It looks like loadeddataHandler is overridden in DashViewer.

DashViewer has no problem because handleVolume in autoplay happens after loadUI in loadeddataHandler in DashViewer.

@mergify mergify bot merged commit 7c6a491 into box:master Sep 6, 2019
@mxiao6 mxiao6 deleted the 6881-sound-icon branch September 6, 2019 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants