Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(errors): Show specific error for conversion failure #1063

Merged
merged 1 commit into from
Sep 3, 2019
Merged

feat(errors): Show specific error for conversion failure #1063

merged 1 commit into from
Sep 3, 2019

Conversation

mickr
Copy link
Contributor

@mickr mickr commented Aug 30, 2019

No description provided.

@mickr mickr requested a review from a team as a code owner August 30, 2019 00:15
@boxcla
Copy link

boxcla commented Aug 30, 2019

Verified that @mickr has signed the CLA. Thanks for the pull request!

@mickr
Copy link
Contributor Author

mickr commented Aug 30, 2019 •
edited
Loading

I still need to catch up about the string value but wanted to get this back open. We're all good to go on the string.

@mickr mickr force-pushed the conrad-conversion-errors branch from ca33284 to a6936ec Compare September 3, 2019 16:51
@mickr mickr removed the do-not-merge label Sep 3, 2019
ConradJChan
ConradJChan approved these changes Sep 3, 2019
View reviewed changes
Copy link
Contributor

@ConradJChan ConradJChan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending the message approval

@mergify mergify bot merged commit effb263 into box:master Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ConradJChan ConradJChan ConradJChan approved these changes

@jstoffan jstoffan jstoffan approved these changes

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mickr @boxcla @jstoffan @ConradJChan