chore(deps): Upgrade to Babel 7 #1047
Conversation
|
Verified that @jstoffan has signed the CLA. Thanks for the pull request! |
| // Pass remaining arguments to parent constructor | ||
| super(...params); | ||
| super(message, ...params); |
There was a problem hiding this comment.
Since the parent constructor wants [message, fileName, lineNumber], you can probably get rid of ...params since latter two are optional and not passed in for PreviewErrors usage.
There was a problem hiding this comment.
Yeah, I didn't see them passed in anywhere, but I wanted to stay as close to the original implementation as possible.
There was a problem hiding this comment.
Also PreviewError's 2nd arg is the message, aka displayMessage, so shouldn't it be super(displayMessage)? And if so, maybe you wont need line 45
There was a problem hiding this comment.
Nope. If both are passed in, this.message should still be the original message, not the display message.
I had to modify the PreviewError class slightly because
this.messagedidn't seem to be getting set properly after being transpiled. It looks like modifying built-ins the way we have can be a little tricky.