fix(api): Add support for http interceptors #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @mickr has signed the CLA. Thanks for the pull request! |
ConradJChan
reviewed
Jul 15, 2019
jstoffan
reviewed
Jul 15, 2019
|
I have updated the other feedback on this PR and I'm going to start working on the api layer refactor. |
jstoffan
reviewed
Jul 18, 2019
mickr
force-pushed
the
use-http-interceptors-in-preview
branch
2 times, most recently
from
569c80b to
1e271e2
Compare
mickr
changed the title
jstoffan
reviewed
Jul 19, 2019
|
The tests have not been updated, I want to go over the changes in the PR before updating the test implementation. |
jstoffan
reviewed
Jul 22, 2019
ConradJChan
reviewed
Jul 22, 2019
| @@ -4,7 +4,7 @@ import EventEmitter from 'events'; | |||
| import cloneDeep from 'lodash/cloneDeep'; | |||
| import throttle from 'lodash/throttle'; | |||
| /* eslint-enable import/first */ | |||
| import api from './api'; | |||
| import Api from './api'; | |||
There was a problem hiding this comment.
I think the preference is that acronyms be uppercased
There was a problem hiding this comment.
What if we are trying to denote that it is a class that requires new?
jstoffan
reviewed
Jul 25, 2019
jstoffan
reviewed
Jul 25, 2019
|
|
||
| // Otherwise, get the content download URL of the original file and download | ||
| } else { | ||
| const getDownloadUrl = appendQueryParams(getDownloadURL(this.file.id, apiHost), queryParams); | ||
| api.get(getDownloadUrl, { headers: this.getRequestHeaders() }).then(data => { | ||
| this.api.get(getDownloadUrl, { headers: this.getRequestHeaders() }).then(data => { |
There was a problem hiding this comment.
In a follow-up, we could probably generalize this to this.api.file.getDownloadUrl and hide the reachability checks from the consumer entirely.
mickr
force-pushed
the
use-http-interceptors-in-preview
branch
from
cac3825 to
8b8516a
Compare
* Add support for using passed in request/response http interceptors. * Add request and response interceptors to documentation * Convert metadata API to a class and encapsulate within the API * Add DownloadReachability to API
mickr
force-pushed
the
use-http-interceptors-in-preview
branch
from
15d79c5 to
583183a
Compare
jstoffan
previously approved these changes
Jul 27, 2019
Changed instantiation point to the constructor and updated the tests.
jstoffan
approved these changes
Jul 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.