Fix: Chrome Print Preview Fix #1030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @mickr has signed the CLA. Thanks for the pull request! |
mickr
changed the title
jeremypress
previously approved these changes
Jul 1, 2019
mickr
changed the title
jstoffan
reviewed
Jul 1, 2019
src/lib/viewers/image/ImageViewer.js
Outdated
| } else { | ||
| this.printframe.contentWindow.print(); | ||
| // Chrome will show preview from iframe before the content is loaded. | ||
| this.printframe.addEventListener('load', defaultPrintHandler); |
There was a problem hiding this comment.
Can there be a situation where the frame has already fired its load event by the time this code executes? Such as if the content is cached? If so, does print still work?
There was a problem hiding this comment.
This code is from a few years ago, but I wonder if we could streamline the code to wait for the 'load' event for all browsers before attempting the print?
There was a problem hiding this comment.
I am updating the code as @ConradJChan suggested for all browsers.
mickr
force-pushed
the
COXP-4819-Chrome-print-preview
branch
from
065a5e5 to
724242b
Compare
* Add listener that is fired once the iframe has loaded it's content for printing. This enables chrome to show an accurate print preview.
Refactor code so that all print calls are async on the load event and the event handler is added earlier in the instantiation process.
mickr
force-pushed
the
COXP-4819-Chrome-print-preview
branch
from
6e18ab1 to
197815b
Compare
ConradJChan
approved these changes
Jul 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables chrome to show an accurate print preview.