Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove bg color for cc button on hover #1025

Merged
merged 1 commit into from
Jun 21, 2019

Conversation

manishPh
Copy link
Contributor

  1. Adding bg color on hover for CC button doesn't play nicely on mobile devices.
  2. Other buttons in media player don't have bg color on hover.
  3. When CC is turned off, user doesn't know because the button is still blue because of the hover effect.

Removing :hover style solves all the above issues.

@boxcla
Copy link

boxcla commented Jun 21, 2019

Hi @manishPh, thanks for the pull request. Before we can merge it, we need you to sign our Contributor License Agreement. You can do so electronically here: http://opensource.box.com/cla

Once you have signed, just add a comment to this pull request saying, "CLA signed". Thanks!

@manishPh
Copy link
Contributor Author

CLA signed

Copy link
Contributor

@ConradJChan ConradJChan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like .bp-media-controls-label, .bp-media-controls-btn uses opacity: .7 by default and then opacity: 1 on hover, would that work here as well?

@manishPh
Copy link
Contributor Author

@ConradJChan yes that experience won't change.

@mergify mergify bot merged commit d41c05b into box:master Jun 21, 2019
@manishPh manishPh deleted the fixCCHoverIssue branch June 21, 2019 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants