Fix: Move notification to be child of preview content #1019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @ConradJChan has signed the CLA. Thanks for the pull request! |
jstoffan
reviewed
Jun 18, 2019
jstoffan
approved these changes
Jun 19, 2019
| @@ -390,7 +390,7 @@ class DocPreloader extends EventEmitter { | |||
| */ | |||
| checkDocumentLoaded() { | |||
| // If document is already loaded, hide the preload and short circuit | |||
| if (this.previewUI.contentContainer.classList.contains(CLASS_PREVIEW_LOADED)) { | |||
| if (this.previewUI.previewContainer.classList.contains(CLASS_PREVIEW_LOADED)) { | |||
There was a problem hiding this comment.
We'll probably want to triple-check that preload is dismissing on load. 😄
jeremypress
approved these changes
Jun 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PreviewUI.js, introduced
previewContainerwhich points to.bpdiv. ExistingcontentContainer(which used to point to.bp) is now.bp-contentwhich is only used for Notification.jsAlso changed the default "Okay" to use the
close.svg