Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New: Show banner when doc has xrefs #1013

Merged
merged 4 commits into from
Jun 10, 2019

Conversation

ConradJChan
Copy link
Contributor

@ConradJChan ConradJChan commented Jun 7, 2019

Todo:

  • unit tests

@boxcla
Copy link

boxcla commented Jun 7, 2019

Verified that @ConradJChan has signed the CLA. Thanks for the pull request!

src/lib/metadataAPI.js Outdated Show resolved Hide resolved
src/lib/viewers/doc/DocBaseViewer.js Outdated Show resolved Hide resolved
src/lib/viewers/doc/DocBaseViewer.js Outdated Show resolved Hide resolved
src/i18n/en-US.properties Outdated Show resolved Hide resolved
src/lib/metadataAPI.js Outdated Show resolved Hide resolved
src/lib/metadataAPI.js Show resolved Hide resolved
src/lib/viewers/doc/DocLoader.js Show resolved Hide resolved
NAME: 'AutoCAD',
CONSTRUCTOR: AutoCADViewer,
REP: 'pdf',
EXT: ['dwg']
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm: Is this the only AutoCAD extension we're supporting?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, there was talk of supporting .dwgzip and .dfx but the latest is that this is the only one

@ConradJChan ConradJChan merged commit 6f9fca7 into box:master Jun 10, 2019
@ConradJChan ConradJChan deleted the xrefs-notification branch June 10, 2019 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants