fix(model3d): Fix react controls to reset to defaults (#1384)

box · May 14, 2021 · f305ea7 · f305ea7
1 parent 79fbd40
commit f305ea7
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/src/lib/viewers/box3d/model3d/Model3DViewer.js b/src/lib/viewers/box3d/model3d/Model3DViewer.js
@@ -350,8 +350,8 @@ class Model3DViewer extends Box3DViewer {
         super.handleReset();
 
         this.setAnimationState(false);
-        this.handleSetCameraProjection(this.projection);
-        this.handleSetRenderMode(this.renderMode);
+        this.handleSetCameraProjection(CAMERA_PROJECTION_PERSPECTIVE);
+        this.handleSetRenderMode(RENDER_MODE_LIT);
         this.handleShowGrid(true);
         this.handleShowSkeletons(false);
         this.handleShowWireframes(false);
@@ -360,8 +360,8 @@ class Model3DViewer extends Box3DViewer {
             if (this.getViewerOption('useReactControls')) {
                 this.renderUI();
             } else {
-                this.controls.handleSetRenderMode(this.renderMode);
-                this.controls.setCurrentProjectionMode(this.projection);
+                this.controls.handleSetRenderMode(RENDER_MODE_LIT);
+                this.controls.setCurrentProjectionMode(CAMERA_PROJECTION_PERSPECTIVE);
                 this.controls.handleSetSkeletonsVisible(false);
                 this.controls.handleSetWireframesVisible(false);
                 this.controls.handleSetGridVisible(this.showGrid);

diff --git a/src/lib/viewers/box3d/model3d/__tests__/Model3DViewer-test.js b/src/lib/viewers/box3d/model3d/__tests__/Model3DViewer-test.js
@@ -833,6 +833,11 @@ describe('lib/viewers/box3d/model3d/Model3DViewer', () => {
 
             test('should reset controls state and call renderUI', () => {
                 model3d.isAnimationPlaying = true;
+                model3d.projection = 'Orthographic';
+                model3d.renderMode = 'Normals';
+                model3d.showGrid = false;
+                model3d.showSkeletons = true;
+                model3d.showWireframes = true;
 
                 model3d.handleReset();