Fix: fix excel setup when enabling the Office viewer via options (#126)

box · May 22, 2017 · e8145f5 · e8145f5
1 parent 81802c1
commit e8145f5
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/src/lib/viewers/office/OfficeViewer.js b/src/lib/viewers/office/OfficeViewer.js
@@ -31,7 +31,8 @@ class OfficeViewer extends BaseViewer {
         super.setup();
         // Set to false only in the WebApp, everywhere else we want to avoid hitting a runmode.
         // This flag will be removed once we run the entire integration through the client.
-        this.platformSetup = this.options.viewers.Office ? !!this.options.viewers.Office.shouldUsePlatformSetup : true;
+        const hasSetupOption = this.options.viewers.Office && 'shouldUsePlatformSetup' in this.options.viewers.Office;
+        this.platformSetup = hasSetupOption ? !!this.options.viewers.Office.shouldUsePlatformSetup : true;
         this.setupIframe();
         this.initPrint();
         this.setupPDFUrl();

diff --git a/src/lib/viewers/office/__tests__/OfficeViewer-test.js b/src/lib/viewers/office/__tests__/OfficeViewer-test.js
@@ -80,16 +80,30 @@ describe('lib/viewers/office/OfficeViewer', () => {
             expect(stubs.setupPDFUrl).to.be.called;
         });
 
-        it('should not use the platform setup if the option is passed in', () => {
+        it('should not determine setup based on the option if it is passed in', () => {
             office.setup();
             expect(office.platformSetup).to.be.false;
+
+            office.options.viewers.Office.shouldUsePlatformSetup = true;
+            office.setup();
+            expect(office.platformSetup).to.be.true;
         });
 
         it('should use the platform setup if no option is passed in', () => {
             office.options.viewers = {};
             office.setup();
             expect(office.platformSetup).to.be.true;
         });
+
+        it('should still use the platform setup if the viewer option, but no setup option exists', () => {
+            office.options.viewers = {
+                Office: {
+                    disabled: false
+                }
+            };
+            office.setup();
+            expect(office.platformSetup).to.be.true;
+        });
     });
 
     describe('destroy()', () => {