feat(controls): Add option for react controls to CSV viewer (#1306)

box · Dec 9, 2020 · e34cc02 · e34cc02
1 parent f9b07fd
commit e34cc02
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 3 deletions.
diff --git a/src/lib/viewers/text/CSVViewer.js b/src/lib/viewers/text/CSVViewer.js
@@ -164,7 +164,12 @@ class CSVViewer extends TextBaseViewer {
         this.csvComponent = new BoxCSV(this.csvEl, this.data);
         this.csvComponent.renderCSV();
 
-        this.loadUI();
+        if (this.options.useReactControls) {
+            this.loadUIReact();
+        } else {
+            this.loadUI();
+        }
+
         this.loaded = true;
         this.emit(VIEWER_EVENT.load);
     }

diff --git a/src/lib/viewers/text/MarkdownViewer.js b/src/lib/viewers/text/MarkdownViewer.js
@@ -116,7 +116,7 @@ class MarkdownViewer extends PlainTextViewer {
     }
 
     renderUI() {
-        if (this.options.useReactControls) {
+        if (this.controls && this.options.useReactControls) {
             this.controls.render(<MarkdownControls onFullscreenToggle={this.toggleFullscreen} />);
         }
     }

diff --git a/src/lib/viewers/text/TextBaseViewer.js b/src/lib/viewers/text/TextBaseViewer.js
@@ -156,7 +156,7 @@ class TextBaseViewer extends BaseViewer {
             this.zoomControls.setCurrentScale(this.scale);
         }
 
-        if (this.options.useReactControls) {
+        if (this.controls && this.options.useReactControls) {
             this.controls.render(
                 <TextControls
                     maxScale={ZOOM_MAX}

diff --git a/src/lib/viewers/text/__tests__/CSVViewer-test.js b/src/lib/viewers/text/__tests__/CSVViewer-test.js
@@ -191,14 +191,27 @@ describe('lib/viewers/text/CSVViewer', () => {
             });
             /* eslint-enable react/prefer-es6-class */
             jest.spyOn(csv, 'loadUI');
+            jest.spyOn(csv, 'loadUIReact');
             jest.spyOn(csv, 'emit');
 
             csv.finishLoading();
 
             expect(csv.loadUI).toBeCalled();
+            expect(csv.loadUIReact).not.toBeCalled();
             expect(csv.loaded).toBe(true);
             expect(csv.emit).toBeCalledWith(VIEWER_EVENT.load);
         });
+
+        test('should finish loading and render react ui if option is enabled', () => {
+            jest.spyOn(csv, 'loadUI');
+            jest.spyOn(csv, 'loadUIReact');
+
+            csv.options.useReactControls = true;
+            csv.finishLoading();
+
+            expect(csv.loadUI).not.toBeCalled();
+            expect(csv.loadUIReact).toBeCalled();
+        });
     });
 
     describe('checkForParseErrors()', () => {