Skip to content

Commit

Permalink
chore(deps): Upgrade node and yarn version requirements (#1163)
Browse files Browse the repository at this point in the history
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
  • Loading branch information
jstoffan and mergify[bot] authored Jan 29, 2020
1 parent 716aa0e commit da4c4ff
Show file tree
Hide file tree
Showing 5 changed files with 41 additions and 208 deletions.
1 change: 1 addition & 0 deletions .nvmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
lts/erbium
4 changes: 2 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
language: node_js
node_js:
- '10'
- '12'
addons:
apt:
packages:
Expand All @@ -11,7 +11,7 @@ cache:
- node_modules
- ~/.cache/Cypress
before_install:
- curl -o- -L https://yarnpkg.com/install.sh | bash -s -- --version 1.13.0
- curl -o- -L https://yarnpkg.com/install.sh | bash -s -- --version 1.19.1
- export PATH=$HOME/.yarn/bin:$PATH
jobs:
include:
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,7 @@ preview.addListener('rotate', data => {

## Development Setup

1. Install latest LTS version of Node v8.9.4 or higher.
1. Install latest LTS version of Node `https://nodejs.org/en/download`.
2. Install yarn package manager `https://yarnpkg.com/en/docs/install`. Alternatively, you can replace any `yarn` command with `npm`.
3. Fork the upstream repo `https://github.com/box/box-content-preview`.
4. Clone your fork locally `git clone [email protected]:[YOUR GITHUB USERNAME]/box-content-preview.git`.
Expand Down
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@
"mock-local-storage": "^1.0.2",
"mojito-rb-gen": "^0.0.1",
"node-noop": "^1.0.0",
"node-sass": "4.9.3",
"node-sass": "4.13.1",
"npm-run-all": "^4.1.5",
"optimize-css-assets-webpack-plugin": "^5.0.3",
"phantomjs-prebuilt": "^2.1.16",
Expand Down Expand Up @@ -116,8 +116,8 @@
"webpack-dev-server": "^3.7.2"
},
"engines": {
"node": ">=8.9.4",
"yarn": ">=1.10.0"
"node": ">=10.x",
"yarn": ">=1.19.x"
},
"scripts": {
"build": "yarn setup && yarn clean && yarn build:i18n && yarn build:dev",
Expand Down
Loading

0 comments on commit da4c4ff

Please sign in to comment.