Chore: Force image point dialogs to re-position on re-render (#280)

box · Aug 7, 2017 · baf9b70 · baf9b70
1 parent a02f3fe
commit baf9b70
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/src/lib/annotations/image/ImagePointThread.js b/src/lib/annotations/image/ImagePointThread.js
@@ -36,6 +36,9 @@ class ImagePointThread extends AnnotationThread {
 
         if (this.state === STATES.pending) {
             this.showDialog();
+
+            // Force dialogs to reposition on re-render
+            this.dialog.position();
         }
     }
 

diff --git a/src/lib/annotations/image/__tests__/ImagePointThread-test.js b/src/lib/annotations/image/__tests__/ImagePointThread-test.js
@@ -25,6 +25,10 @@ describe('lib/annotations/image/ImagePointThread', () => {
             threadID: 2,
             type: 'point'
         });
+
+        thread.dialog = {
+            position: sandbox.stub()
+        };
     });
 
     afterEach(() => {
@@ -55,6 +59,7 @@ describe('lib/annotations/image/ImagePointThread', () => {
             thread.show();
 
             expect(thread.showDialog).to.have.been.called;
+            expect(thread.dialog.position).to.have.been.called;
         });
 
         it('should not show the dialog if the state is not pending', () => {