Fix: isPageNumFocused() null check (#401)

box · Sep 18, 2017 · b7eb6dc · jeremypress · Sep 26, 2017 · b7eb6dc
1 parent ba4f354
commit b7eb6dc
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 4 deletions.
diff --git a/src/lib/Controls.js b/src/lib/Controls.js
@@ -243,7 +243,7 @@ class Controls {
      * @return {boolean} Is the input focused
      */
     isPageNumFocused() {
-        return document.activeElement.classList.contains(CONTROLS_PAGE_NUM_INPUT_CLASS);
+        return document.activeElement && document.activeElement.classList.contains(CONTROLS_PAGE_NUM_INPUT_CLASS);
     }
 }
 

diff --git a/src/lib/__tests__/Controls-test.js b/src/lib/__tests__/Controls-test.js
@@ -286,4 +286,16 @@ describe('lib/Controls', () => {
             expect(controls.controlsEl.classList.contains(CLASS_HIDDEN)).to.be.true;
         });
     });
+
+    describe('isPageNumFocused()', () => {
+        it('should return true if page num element is focused', () => {
+            document.activeElement.classList.add('bp-page-num-input');
+            expect(controls.isPageNumFocused()).to.be.true;
+        });
+
+        it('should return false if page num element is not', () => {
+            document.activeElement.classList.remove('bp-page-num-input');
+            expect(controls.isPageNumFocused()).to.be.false;
+        });
+    })
 });
diff --git a/src/lib/viewers/doc/_docBase.scss b/src/lib/viewers/doc/_docBase.scss
@@ -32,14 +32,11 @@
 
     //---------- Override CSS from generic PDFJS viewer build ----------//
     .pdfViewer .page {
-        align-items: center;
         border: 0;
         border-image: none;
         /* stylelint-disable declaration-no-important */
         box-sizing: content-box !important;
         /* stylelint-enable declaration-no-important */
-        display: flex;
-        justify-content: center;
         margin: 0 auto;
         // We use padding instead of margin to push down since we want to
         // include this padding when PDF.js jumps to pages