From 9e042c12d960f6f7b1c3970eea9bfd49b9121068 Mon Sep 17 00:00:00 2001 From: Sumedha Pramod Date: Mon, 10 Jul 2017 13:12:13 -0700 Subject: [PATCH] Chore: Cleaning up annotations code comments (#206) --- src/lib/annotations/AnnotationDialog.js | 3 +-- src/lib/annotations/Annotator.js | 3 --- src/lib/viewers/image/ImageBaseViewer.js | 4 ---- 3 files changed, 1 insertion(+), 9 deletions(-) diff --git a/src/lib/annotations/AnnotationDialog.js b/src/lib/annotations/AnnotationDialog.js index 8035a1c89..006647c04 100644 --- a/src/lib/annotations/AnnotationDialog.js +++ b/src/lib/annotations/AnnotationDialog.js @@ -161,7 +161,6 @@ const CLASS_ANIMATE_DIALOG = 'bp-animate-show-dialog'; /** * Hides the dialog. * - * @param {boolean} [noDelay] - Whether or not to have a timeout delay * @return {void} */ hide() { @@ -319,7 +318,7 @@ const CLASS_ANIMATE_DIALOG = 'bp-animate-show-dialog'; const key = decodeKeydown(event); if (key === 'Escape') { - this.hide(); // hide without delay + this.hide(); } else { const dataType = annotatorUtil.findClosestDataType(event.target); if (dataType === 'reply-textarea') { diff --git a/src/lib/annotations/Annotator.js b/src/lib/annotations/Annotator.js index 3c1525ded..8c401e19c 100644 --- a/src/lib/annotations/Annotator.js +++ b/src/lib/annotations/Annotator.js @@ -202,9 +202,6 @@ import './Annotator.scss'; } // Hide create annotations button if image is rotated - // TODO(@spramod) actually adjust getLocationFromEvent method - // in annotator to get correct location rather than disabling - // the creation of annotations on rotated images const annotateButton = this.previewUI.getAnnotateButton(); if (rotationAngle !== 0) { diff --git a/src/lib/viewers/image/ImageBaseViewer.js b/src/lib/viewers/image/ImageBaseViewer.js index 2ff04d496..2569f59e6 100644 --- a/src/lib/viewers/image/ImageBaseViewer.js +++ b/src/lib/viewers/image/ImageBaseViewer.js @@ -317,10 +317,6 @@ const CSS_CLASS_PANNABLE = 'pannable'; event.stopPropagation(); } - //---------------------------------------------------------------------------------------------- - // Annotations. TODO(jholdstock|spramod) Refactor out all annotations code from viewers - //---------------------------------------------------------------------------------------------- - /** * Disables viewer controls *