Fix: Passing event into thread.mouseoutHandler() (#375)

box · Sep 8, 2017 · 2fe3c37 · 2fe3c37
1 parent fe15754
commit 2fe3c37
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/src/lib/annotations/AnnotationThread.js b/src/lib/annotations/AnnotationThread.js
@@ -479,9 +479,14 @@ class AnnotationThread extends EventEmitter {
      * Mouseout handler. Hides dialog if we aren't creating the first one.
      *
      * @private
+     * @param {HTMLEvent} event - DOM event
      * @return {void}
      */
-    mouseoutHandler() {
+    mouseoutHandler(event) {
+        if (!event) {
+            return;
+        }
+
         const mouseInDialog = annotatorUtil.isInDialog(event, this.dialog.element);
 
         if (this.annotations.length !== 0 && !mouseInDialog) {

diff --git a/src/lib/annotations/__tests__/AnnotationThread-test.js b/src/lib/annotations/__tests__/AnnotationThread-test.js
@@ -608,9 +608,15 @@ describe('lib/annotations/AnnotationThread', () => {
     });
 
     describe('mouseoutHandler()', () => {
+        it('should do nothing if event does not exist', () => {
+            stubs.isInDialog = sandbox.stub(annotatorUtil, 'isInDialog');
+            thread.mouseoutHandler();
+            expect(stubs.isInDialog).to.not.be.called;
+        });
+
         it('should not call hideDialog if there are no annotations in the thread', () => {
             stubs.hide = sandbox.stub(thread, 'hideDialog');
-            thread.mouseoutHandler();
+            thread.mouseoutHandler({});
             expect(stubs.hide).to.not.be.called;
         });
 
@@ -627,7 +633,7 @@ describe('lib/annotations/AnnotationThread', () => {
             });
 
             thread.annotations = [annotation];
-            thread.mouseoutHandler();
+            thread.mouseoutHandler({});
             expect(stubs.hide).to.be.called;
         });
     });