From 2cacedd4a1a44d0a92f133249a63b139dfde5fcb Mon Sep 17 00:00:00 2001
From: bhh1988 <bhh1988@gmail.com>
Date: Tue, 23 May 2017 13:37:52 -0700
Subject: [PATCH] Chore: Settings.js - Declare class properties at class-level
 (#134)

This makes class properties more explicit
---
 src/lib/viewers/media/Settings.js | 59 ++++++++++++++++++++++++++++---
 1 file changed, 55 insertions(+), 4 deletions(-)

diff --git a/src/lib/viewers/media/Settings.js b/src/lib/viewers/media/Settings.js
index e32ae01ac..b827aeadc 100644
--- a/src/lib/viewers/media/Settings.js
+++ b/src/lib/viewers/media/Settings.js
@@ -106,6 +106,61 @@ const SUBTITLES_SUBITEM_TEMPLATE = `<div class="bp-media-settings-sub-item" data
 
 @autobind
 class Settings extends EventEmitter {
+    /**
+     * The container of the settings element
+     *
+     * @property {HTMLElement}
+     */
+    containerEl;
+
+    /**
+     * The settings element
+     *
+     * @property {HTMLElement}
+     */
+    settingsEl;
+
+    /**
+     * The first item in the main menu
+     *
+     * @property {HTMLElement}
+     */
+    firstMenuItem;
+
+    /**
+     * The settings button element (gear icon that opens up the menu)
+     *
+     * @property {HTMLElement}
+     */
+    settingsButtonEl;
+
+    /**
+     * Whether the settings menu is visible or hiding
+     *
+     * @property {boolean}
+     */
+    visible = false;
+
+    /**
+     * List of subtitles in the menu. The subtitles menu will be populated in this order
+     *
+     * @property {array}
+     */
+    subtitles = [];
+
+    /**
+     * Default language to use for choosing subtitle to toggle on
+     *
+     * @property {string}
+     */
+    language = undefined;
+
+    /**
+     * An index (an integer >= 0) into the subtitles list, that should be toggled to when CC toggled on
+     *
+     * @property {string}
+     */
+    toggleToSubtitle = undefined;
 
     /**
      * Service to handle the position and movement of a slider element
@@ -125,11 +180,7 @@ class Settings extends EventEmitter {
         this.settingsButtonEl = this.containerEl.querySelector('.bp-media-gear-icon');
 
         addActivationListener(this.settingsEl, this.menuEventHandler);
-        this.visible = false;
         this.containerEl.classList.add(CLASS_SETTINGS_SUBTITLES_UNAVAILABLE);
-        this.subtitles = [];
-        this.language = undefined;
-        this.toggleToSubtitle = undefined; // An index into the subtitles list. Initialize with sentinel value
         this.init();
     }