feat(permissions): Add checks for new permission values on file object (

#1207)
box · May 12, 2020 · 1f7cda6 · 1f7cda6
1 parent b0c4a62
commit 1f7cda6
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 3 deletions.
diff --git a/src/lib/viewers/BaseViewer.js b/src/lib/viewers/BaseViewer.js
@@ -995,6 +995,8 @@ class BaseViewer extends EventEmitter {
 
         return !!(
             permissions.can_annotate ||
+            permissions.can_create_annotations ||
+            permissions.can_view_annotations ||
             permissions.can_view_annotations_all ||
             permissions.can_view_annotations_self
         );

diff --git a/src/lib/viewers/__tests__/BaseViewer-test.js b/src/lib/viewers/__tests__/BaseViewer-test.js
@@ -1156,9 +1156,11 @@ describe('lib/viewers/BaseViewer', () => {
 
     describe('hasAnnotationPermissions()', () => {
         const permissions = {
-            can_annotate: false,
-            can_view_annotations_all: false,
-            can_view_annotations_self: false,
+            can_annotate: false, // Old
+            can_create_annotations: false, // New
+            can_view_annotations: false, // New
+            can_view_annotations_all: false, // Old
+            can_view_annotations_self: false, // Old
         };
 
         it('does nothing if file permissions are undefined', () => {
@@ -1169,6 +1171,16 @@ describe('lib/viewers/BaseViewer', () => {
             expect(base.hasAnnotationPermissions(permissions)).to.be.false;
         });
 
+        it('should return true if the user can at least create annotations', () => {
+            permissions.can_create_annotations = true;
+            expect(base.hasAnnotationPermissions(permissions)).to.be.true;
+        });
+
+        it('should return true if the user can at least view annotations', () => {
+            permissions.can_view_annotations = true;
+            expect(base.hasAnnotationPermissions(permissions)).to.be.true;
+        });
+
         it('should return true if the user can at least view all annotations', () => {
             permissions.can_view_annotations_all = true;
             expect(base.hasAnnotationPermissions(permissions)).to.be.true;