Fix: pass get failure through in case imageEl is a div of images (#338)

box · Aug 28, 2017 · 1de741e · 1de741e
1 parent c6dac8a
commit 1de741e
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 5 deletions.
diff --git a/src/lib/viewers/image/ImageBaseViewer.js b/src/lib/viewers/image/ImageBaseViewer.js
@@ -178,11 +178,11 @@ class ImageBaseViewer extends BaseViewer {
      * naturalHeight and naturalWidth attributes work correctly in IE 11.
      *
      * @private
-     * @param {Image} imageEl - The image to set the original size attributes on
+     * @param {HTMLElement} imageEl - The image to set the original size attributes on
      * @return {Promise} A promise that is resolved if the original image dimensions were set.
      */
     setOriginalImageSize(imageEl) {
-        const promise = new Promise((resolve, reject) => {
+        const promise = new Promise((resolve) => {
             // Do not bother loading a new image when the natural size attributes exist
             if (imageEl.naturalWidth && imageEl.naturalHeight) {
                 imageEl.setAttribute('originalWidth', imageEl.naturalWidth);
@@ -205,15 +205,15 @@ class ImageBaseViewer extends BaseViewer {
                             const aspectRatio = h ? w / h : w;
                             imageEl.setAttribute('originalWidth', Math.round(aspectRatio * 150));
                             imageEl.setAttribute('originalHeight', 150);
-                            resolve();
                         } catch (e) {
                             // Assume 300x150 that chrome does by default
                             imageEl.setAttribute('originalWidth', 300);
                             imageEl.setAttribute('originalHeight', 150);
-                            resolve(e);
+                        } finally {
+                            resolve();
                         }
                     })
-                    .catch(reject);
+                    .catch(resolve);
             }
         });
 

diff --git a/src/lib/viewers/image/__tests__/ImageBaseViewer-test.js b/src/lib/viewers/image/__tests__/ImageBaseViewer-test.js
@@ -260,6 +260,17 @@ describe('lib/viewers/image/ImageBaseViewer', () => {
                 Assert.fail();
             });
         });
+
+        it('should resolve when the get call fails', (done) => {
+            const imageEl = {};
+            const getStub = sandbox.stub(util, 'get').returns(Promise.reject());
+            const promise = imageBase.setOriginalImageSize(imageEl);
+            promise.should.be.fulfilled.then(() => {
+                done();
+            }).catch(() => {
+                Assert.fail();
+            });
+        });
     });
 
     describe('bindControlListeners()', () => {