Skip to content

Commit

Permalink
Revert "Chore: Temporarily allow draw annotations to be enabled via c…
Browse files Browse the repository at this point in the history
…onfig (#416)" (#434)
  • Loading branch information
Jeremy Press authored Oct 13, 2017
1 parent 86072bd commit 09c279d
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 25 deletions.
3 changes: 1 addition & 2 deletions src/lib/annotations/BoxAnnotations.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@ const ANNOTATORS = [
NAME: 'Document',
CONSTRUCTOR: DocAnnotator,
VIEWER: ['Document', 'Presentation'],
// Temporarily include draw annotations for demo purposes
TYPE: [TYPES.point, TYPES.highlight, TYPES.highlight_comment, TYPES.draw]
TYPE: [TYPES.point, TYPES.highlight, TYPES.highlight_comment]
},
{
NAME: 'Image',
Expand Down
23 changes: 0 additions & 23 deletions src/lib/annotations/__tests__/BoxAnnotations-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -131,29 +131,6 @@ describe('lib/annotators/BoxAnnotations', () => {
});
expect(stubs.instantiateControllers).to.be.called;
});

// Temporary test for demo purposes
it('should remove draw annotations unless explicitly enabled', () => {
let config = {
enabled: true,
drawEnabled: true,
disabledTypes: ['point']
};
const docAnnotator = {
NAME: 'Document',
VIEWER: ['Document'],
TYPE: ['point', 'highlight', 'draw']
};

loader.annotators = [docAnnotator];

annotator = loader.determineAnnotator('Document', {}, config);
expect(annotator.TYPE.includes('draw')).to.be.true;

config.drawEnabled = undefined;
let annotator = loader.determineAnnotator('Document', {}, config);
expect(annotator.TYPE.includes('draw')).to.be.false;
});
});

describe('instantiateControllers()', () => {
Expand Down

0 comments on commit 09c279d

Please sign in to comment.